deis / router

Edge router for Deis Workflow
https://deis.com
MIT License
80 stars 57 forks source link

feat(charts): add resource requests to chart #311

Closed bookshelfdave closed 7 years ago

bookshelfdave commented 7 years ago
deis-admin commented 7 years ago

Thanks for the contribution! Please ensure your commits follow our style guide. This code will be tested once a Deis maintainer reviews it.

mboersma commented 7 years ago

Could you amend the commit message to follow the commit style guide? That way it will get picked up by deisrel when we generate the release changelog.

Jenkins, add to whitelist.

codecov-io commented 7 years ago

Codecov Report

Merging #311 into master will not impact coverage.

@@           Coverage Diff           @@
##           master     #311   +/-   ##
=======================================
  Coverage   55.69%   55.69%           
=======================================
  Files           6        6           
  Lines         386      386           
=======================================
  Hits          215      215           
  Misses        151      151           
  Partials       20       20

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 55a38f6...74449a6. Read the comment docs.

bookshelfdave commented 7 years ago

fixed, thank you @mboersma

mboersma commented 7 years ago

I've tested this manually and it looks like the resources: stanza is created correctly when need be.

bookshelfdave commented 7 years ago

thank you @mboersma!