deis / router

Edge router for Deis Workflow
https://deis.com
MIT License
80 stars 57 forks source link

chore(Makefile): Eliminate DEV_ENV_CMD_INT #318

Closed krancour closed 7 years ago

krancour commented 7 years ago

Minor thing...

Something I've learned since I first crafted this Makefile (and others like it for other repos)...

You don't have to skip the -it when you don't care about a container running interactively and with a tty... and in fact, if you just always include the -it, we even get colorized output in places where we didn't previously.

krancour commented 7 years ago

Welp... nevermind. Jenkins doesn't like it, because it's incapable of attaching a tty to the container. Closing.