deis / router

Edge router for Deis Workflow
https://deis.com
MIT License
80 stars 57 forks source link

fix(charts): quote annotation values #328

Closed mboersma closed 7 years ago

mboersma commented 7 years ago

I get errors trying to set service_annotations or deployment_annotations in testing #323. Templating the router service seems to be the initial problem, because the range loop doesn't quote the values as required.

Closes #325.

codecov-io commented 7 years ago

Codecov Report

Merging #328 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #328   +/-   ##
=======================================
  Coverage   55.69%   55.69%           
=======================================
  Files           6        6           
  Lines         386      386           
=======================================
  Hits          215      215           
  Misses        151      151           
  Partials       20       20

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f81d872...65b7487. Read the comment docs.

bacongobbler commented 7 years ago

I'll see if I can get service annotations working with this fix.

bacongobbler commented 7 years ago

This worked for me. LGTM!

><> cat workflow/values.yaml | grep proxyBuffers
    router.deis.io/nginx.proxyBuffers.enabled: "true"
><> kd get deploy deis-router -o yaml | grep proxy
    router.deis.io/nginx.proxyBuffers.enabled: "true"