Add NGiNX Status endpoint to Healthcheck server

[deis-admin]

Thanks for the contribution! Please ensure your commits follow our style guide. This code will be tested once a Deis maintainer reviews it.

[deis-bot]

@krancour, @lachie83 and @robholland are potential reviewers of this pull request based on my analysis of git blame information. Thanks @pixeleet!

[codecov-io]

Codecov Report

Merging #335 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #335   +/-   ##
=======================================
  Coverage   56.47%   56.47%           
=======================================
  Files           6        6           
  Lines         425      425           
=======================================
  Hits          240      240           
  Misses        159      159           
  Partials       26       26

Impacted Files	Coverage Δ
nginx/config.go	56.86% <ø> (ø)	:arrow_up:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b8e207e...d16b111. Read the comment docs.

[krancour]

I added the manual testing label. @pixeleet can you confirm that this is working? I haven't actually tried it; have only looked at the diff.

[pixeleet]

I can confirm that it works in a simple nginx implementation with the exact same code, I'd have to go and install this version of the router, and I have a long way to go before I'm ready to go 2.13 or what's the latest and greatest Deis release.

[krancour]

@pixeleet... if you do a stock install of deis/workflow in minikube or a development cluster, the command make deploy executed from the root of this repo will build the router from source, build it into a Docker image, and then swap that for the existing router in your cluster.

[deis-admin]

Thanks for the contribution! Please ensure your commits follow our style guide. This code will be tested once a Deis maintainer reviews it.

[bacongobbler]

Alternatively you can also do a kubectl -n deis edit deploy deis-router and change the image name to quay.io/deisci/router:git-d16b111. That's the image jenkins just built and pushed to test this PR.

[pixeleet]

@bacongobbler Can't seem to pull the image. Do I need to setup secrets to access your Quay Repo?

18s        33s         2         deis-router-1387728611-mcb4z    Pod       spec.containers{deis-router}    Normal    Pulling      {kubelet ip-10-0-10-73.eu-central-1.compute.internal}    pulling image "quay.io/deisci/router:git-d16b111"
15s        31s         2         deis-router-1387728611-mcb4z    Pod       spec.containers{deis-router}    Warning   Failed       {kubelet ip-10-0-10-73.eu-central-1.compute.internal}    Failed to pull image "quay.io/deisci/router:git-d16b111": image pull failed for quay.io/deisci/router:git-d16b111, this may be because there are no credentials on this request.  details: (Tag git-d16b111 not found in repository quay.io/deisci/router)
15s        31s         2         deis-router-1387728611-mcb4z    Pod                                       Warning   FailedSync   {kubelet ip-10-0-10-73.eu-central-1.compute.internal}    Error syncing pod, skipping: failed to "StartContainer" for "deis-router" with ErrImagePull: "image pull failed for quay.io/deisci/router:git-d16b111, this may be because there are no credentials on this request.  details: (Tag git-d16b111 not found in repository quay.io/deisci/router)"

4s        30s       2         deis-router-1387728611-mcb4z   Pod       spec.containers{deis-router}   Normal    BackOff      {kubelet ip-10-0-10-73.eu-central-1.compute.internal}   Back-off pulling image "quay.io/deisci/router:git-d16b111"
4s        30s       2         deis-router-1387728611-mcb4z   Pod                                      Warning   FailedSync   {kubelet ip-10-0-10-73.eu-central-1.compute.internal}   Error syncing pod, skipping: failed to "StartContainer" for "deis-router" with ImagePullBackOff: "Back-off pulling image \"quay.io/deisci/router:git-d16b111\""

[pixeleet]

Just built it locally and YOLO'd it into production, I'm seeing stats coming in from Nginx into Sysdig. Things seem to have not broken :P

[krancour]

@bacongobbler can you LGTM?

[bacongobbler]

LGTM3