search

deis / router

Edge router for Deis Workflow
https://deis.com
MIT License
80 stars 57 forks source link

fix(charts): remove b64enc from dhparam #338

Closed mpon closed 7 years ago

mpon commented 7 years ago

I found that the dhparam value was applied two times base64 encoding. I think it is unnecessary here, written in README below following.

Include the base64 encoded dhparam in a secret:

codecov-io commented 7 years ago

Codecov Report

Merging #338 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #338   +/-   ##
=======================================
  Coverage   56.47%   56.47%           
=======================================
  Files           6        6           
  Lines         425      425           
=======================================
  Hits          240      240           
  Misses        159      159           
  Partials       26       26

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7988fef...e559768. Read the comment docs.

krancour commented 7 years ago

This appears to address a legitimate bug that looks to have been introduced in the transition from helm classic charts to helm 2.0+ charts. @mboersma or @bacongobbler can either of you just double-check this?

mboersma commented 7 years ago

Yep, looks like an old bug to me as well. This makes it agree with the docs, as well as the other router params that are required to be pre-encoded with base64. Thanks @mpon!