Closed Bregor closed 7 years ago
Jenkins, OK to test
Merging #344 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #344 +/- ##
=======================================
Coverage 56.47% 56.47%
=======================================
Files 6 6
Lines 425 425
=======================================
Hits 240 240
Misses 159 159
Partials 26 26
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update c31737d...c9769fe. Read the comment docs.
Jenkins, test this please
@Bregor thank you for this contribution. I made several comments, but I want to tell you that overall, this looks great!
@krancour thank you very much for your comments! I will try to achieve them in couple hours.
Jenkins, add to whitelist
@krancour thank you once again for you comments and sorry for too long waiting. Fixed and rebased.
@Bregor did your own testing show that router still worked fine with the reduced permissions?
@krancour I still can create/delete app, set domains an so on.
Thanks, @Bregor. LGTM. Waiting for one other LGTM.
With this change
deis-router
became available to work in RBAC-only clustersWorks with both Kubernetes 1.5 and 1.6 (see
templates/_helpers.tmpl
for details) Actually tested with 1.5.7 and 1.6.2Role allows
deis-router
:extensions/deployments
:get
apps/deployments
:get
ClusterRole allows
deis-router
:services
:get
andlist
secrets
:get
endpoints
:get