deis / router

Edge router for Deis Workflow
https://deis.com
MIT License
80 stars 57 forks source link

RBAC support #344

Closed Bregor closed 7 years ago

Bregor commented 7 years ago

With this change deis-router became available to work in RBAC-only clusters

Works with both Kubernetes 1.5 and 1.6 (see templates/_helpers.tmpl for details) Actually tested with 1.5.7 and 1.6.2

Role allows deis-router:

ClusterRole allows deis-router:

vdice commented 7 years ago

Jenkins, OK to test

codecov-io commented 7 years ago

Codecov Report

Merging #344 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #344   +/-   ##
=======================================
  Coverage   56.47%   56.47%           
=======================================
  Files           6        6           
  Lines         425      425           
=======================================
  Hits          240      240           
  Misses        159      159           
  Partials       26       26

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c31737d...c9769fe. Read the comment docs.

vdice commented 7 years ago

Jenkins, test this please

krancour commented 7 years ago

@Bregor thank you for this contribution. I made several comments, but I want to tell you that overall, this looks great!

Bregor commented 7 years ago

@krancour thank you very much for your comments! I will try to achieve them in couple hours.

vdice commented 7 years ago

Jenkins, add to whitelist

Bregor commented 7 years ago

@krancour thank you once again for you comments and sorry for too long waiting. Fixed and rebased.

krancour commented 7 years ago

@Bregor did your own testing show that router still worked fine with the reduced permissions?

Bregor commented 7 years ago

@krancour I still can create/delete app, set domains an so on.

krancour commented 7 years ago

Thanks, @Bregor. LGTM. Waiting for one other LGTM.