search

deis / router

Edge router for Deis Workflow
https://deis.com
MIT License
80 stars 57 forks source link

fix(nginx) wait for nginx reload to avoid zombies #356

Open felixbuenemann opened 6 years ago

felixbuenemann commented 6 years ago

If a unix process is spawned, the parent process must wait for its pid or the process will become a zombie after exit. This fixes the problem that the /opt/router/sbin/router binary leaves behing a defunct nginx process each time the config is reloaded by spawning "nginx -s reload".

Fixes #331.

deis-admin commented 6 years ago

Thanks for the contribution! Please ensure your commits follow our style guide. This code will be tested once a Deis maintainer reviews it.

krancour commented 6 years ago

@felixbuenemann to the best of my knowledge, no one is actively maintaining the old components of Deis Workflow anymore.

Cryptophobia commented 6 years ago

Hi @felixbuenemann and @krancour . I am from the Fork of Deis Workflow team - Hephy. https://github.com/teamhephy/

This is a good PR and we actually encountered a problem with this yesterday. Please can you make this PR against hephy-router repository and we can merge it in and get it into the first release.

Here is repository for the hephy-router: https://github.com/teamhephy/router