search

deis / slugrunner

Buildpack application runner for Deis Workflow.
https://deis.com
MIT License
13 stars 18 forks source link

feat(storage): Add support for multiple object storages #24

Closed kmala closed 8 years ago

kmala commented 8 years ago

Add support for multiple object storages

arschles commented 8 years ago

@kmala it would be much better here to use the proposed command line client. I also noticed that you started polishing up the generic storage package at https://github.com/deis/distribution/pull/7.

kmala commented 8 years ago

@arschles since anyway we are going to rewrite in Go where we can use the https://github.com/deis/distribution/pull/7, i thought it would be simple to do this way.

arschles commented 8 years ago

@kmala I'm not aware of any plans to rewrite this in Go, as it's not on the issues queue

kmala commented 8 years ago

@arschles i mistook this for slugbuilder where i saw your PR(https://github.com/deis/slugbuilder/pull/9)

arschles commented 8 years ago

Ok. Regardless, we do need a solution for slugrunner, and I believe having a single CLI based on our centralized SDK is it, rather than a second implementation in python as seen here.

arschles commented 8 years ago

Also note that https://github.com/deis/slugbuilder/pull/9 is highly experimental. I don't believe it even works anymore....

kmala commented 8 years ago

fixes #18

arschles commented 8 years ago

Echoing my comment about the CLI from https://github.com/deis/slugbuilder/pull/41#issuecomment-202469800 in here

arschles commented 8 years ago

according to https://github.com/deis/slugrunner/pull/24#discussion_r57812927, code LGTM.