fix(Makefile): ensure to use "latest" build of cedar:14

deis / slugrunner

Buildpack application runner for Deis Workflow.

https://deis.com

MIT License

13 stars 18 forks source link

fix(Makefile): ensure to use "latest" build of cedar:14 #52

Closed bacongobbler closed 8 years ago

bacongobbler commented 8 years ago

Heroku constantly updates the heroku/cedar:14 image as security patches are applied. This change enforces us to pull down the latest version of the image before building the image.

This should help with the security vulnerabilities noticed at https://quay.io/repository/deis/slugrunner/image/be8ee4d86705adf1c520ce18851b4b253219c979eb0e2089566dcd5b87154bd0?tab=vulnerabilities

deis-bot commented 8 years ago

@mboersma is a potential reviewer of this pull request based on my analysis of git blame information. Thanks @bacongobbler!

bacongobbler commented 8 years ago

refs https://github.com/deis/slugrunner/issues/47

bacongobbler commented 8 years ago

today I learned about docker build --pull:

Always attempt to pull a newer version of the image

Joshua-Anderson commented 8 years ago

Should we also do the same thing for slugbuilder?

bacongobbler commented 8 years ago

Yep! Finally sitting down at the airport. I'm going to implement this org-wide.