feat(k8s/broker): add broker control loop

deis / steward-framework

Go SDK for the Service Catalog Controller API

MIT License

6 stars 3 forks source link

feat(k8s/broker): add broker control loop #22

Closed arschles closed 8 years ago

arschles commented 8 years ago

Fixes #15

codecov-io commented 8 years ago

Current coverage is 62.14% (diff: 60.57%)

Merging #22 into master will decrease coverage by 4.52%

@@             master        #22   diff @@
==========================================
  Files             4         10     +6   
  Lines            36        140   +104   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits             24         87    +63   
- Misses           11         48    +37   
- Partials          1          5     +4

Powered by Codecov. Last update bd3d7bb...d81876c

krancour commented 8 years ago

This mostly looks pretty good. I made a few suggestions and asked a few question, in some cases mostly for my own edification.

arschles commented 8 years ago

@krancour changes made. PTAL again

krancour commented 8 years ago

LGTM pending some mutually satisfying conclusion on this discussion: https://github.com/deis/steward-framework/pull/22#discussion_r87626120

arschles commented 8 years ago

@krancour replied on https://github.com/deis/steward-framework/pull/22#discussion_r87626120. let me know what you think