search

deis / steward-framework

Go SDK for the Service Catalog Controller API
MIT License
6 stars 3 forks source link

feat(k8s/binding,k8s/data,k8s): add a binding control loop #33

Closed arschles closed 8 years ago

arschles commented 8 years ago

Fixes #17

codecov-io commented 8 years ago

Current coverage is 50.84% (diff: 46.66%)

No coverage report found for master at a945ba5.

Powered by Codecov. Last update a945ba5...53377b4

krancour commented 8 years ago

@arschles I know there are some open questions surrounding deletion of different resource types, but I don't think the matter of whether we must unbind when a binding is deleted is in question, is it? Can I suggest a delete handler be added to this PR?

arschles commented 8 years ago

@krancour I'd like to get this PR merged so we can move on to testing steward-cf. I've captured the binding deletion logic in https://github.com/deis/steward-framework/issues/45

krancour commented 8 years ago

@arschles if you can either comment on or act on https://github.com/deis/steward-framework/pull/33#discussion_r88280778, then I think this LGTM.

arschles commented 8 years ago

@krancour I addressed that comment with https://github.com/deis/steward-framework/commit/1d19b5cf2fd43e07d1be442b6a78f9d6b7277e2e