deis / steward-framework

Go SDK for the Service Catalog Controller API
MIT License
6 stars 3 forks source link

fix(k8s/loops): Execute StartControlLoops in a goroutine #48

Closed krancour closed 7 years ago

krancour commented 7 years ago

The call to k8s.StartControlLoops() was blocking and stopping the API server from ever starting-- which in turn lead to failing health checks.

codecov-io commented 7 years ago

Current coverage is 51.56% (diff: 100%)

Merging #48 into master will not change coverage

@@             master        #48   diff @@
==========================================
  Files            21         21          
  Lines           415        415          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            214        214          
  Misses          172        172          
  Partials         29         29          

Powered by Codecov. Last update da67def...c6050dc