deis / steward-framework

Go SDK for the Service Catalog Controller API
MIT License
6 stars 3 forks source link

fix(logger): Improve logger names #50

Closed krancour closed 7 years ago

krancour commented 7 years ago

loggo loggers exist in a hierarchy and the dotted names denote where a logger exists within that hierarchy. Ordinarily, the "root logger" ("") is used for a main package and all other loggers' names reflect their location relative to that. Contextually, this information can be important when attempting to identify the source of a log message.

Since this framework doesn't contain a main package, but is used by executable programs that do (e.g. steward-cf), I feel things are kept a bit more tidy, and logs kept more accurate and informative if the logger names used throughout this project are all relative to framework and not "".

codecov-io commented 7 years ago

Current coverage is 51.56% (diff: 100%)

Merging #50 into master will not change coverage

@@             master        #50   diff @@
==========================================
  Files            21         21          
  Lines           415        415          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            214        214          
  Misses          172        172          
  Partials         29         29          

Powered by Codecov. Last update 84d53af...82ea7ef