search

deis / steward

The Kubernetes-native Service Broker.
https://deis.com/
MIT License
154 stars 16 forks source link

fix(glide): add lots more glide ignores #197

Closed arschles closed 8 years ago

arschles commented 8 years ago

Also pinning versions for our explicit deps

cc/ @krancour

krancour commented 8 years ago

More ignores == more better. I am :100: on that.

Re: pinning some packages to specific git shas... that makes me more uneasy. Coffee shop wifi is screwing me over atm, but so far it seems I can avoid most issues we experienced earlier by just pinning k8s.io/kubernetes to a semver (1.3.7).

Maybe combining your extra ignore and my one pin will be the ideal combo?

krancour commented 8 years ago

... Although your ignores might obviate the need to pin k8s to a specific version.

In either event, I just want to see if we can get by without pinning other stuffs to git shas.

arschles commented 8 years ago

@krancour this might be obviated by https://github.com/deis/steward/pull/198 in the future, but I think we should still be figuring it out in the meantime. On that note, care to branch off of this and try your pin-to-k8s-semver strategy?

krancour commented 8 years ago

@arschles this is obviated by 198. Closing.