search

deis / workflow-cli

The CLI for Deis Workflow
http://deis.com
MIT License
31 stars 43 forks source link

Extract common Jenkinsfile logic into Pipeline Global Library #142

Open vdice opened 8 years ago

vdice commented 8 years ago

This repo's Jenkinsfile as well as the controller-sdk-go repo's Jenkinsfile share common logic, especially as of https://github.com/deis/controller-sdk-go/pull/46 which builds workflow-cli in place, duplicating many steps used in this repo's pipeline.

It would be preferable if we extracted shared logic into common functionality via the Pipeline Global Library to both reduce duplication and enable only making changes to such functionality in one location. Some functionality will even prove to be generally useful outside of workflow-cli/controller-sdk-go's scope, such as sending email notifications on e2e failures.

vdice commented 7 years ago

A first attempt at following the resources mentioned in the description didn't pan out very well, but it looks like there has been more activity on https://issues.jenkins-ci.org/browse/JENKINS-31155 which might be useful when this is pulled in.

mboersma commented 7 years ago

Also there's https://github.com/jenkinsci/workflow-remote-loader-plugin which might help.

Cryptophobia commented 6 years ago

This issue was moved to teamhephy/workflow-cli#24