search

deis / workflow-cli

The CLI for Deis Workflow
http://deis.com
MIT License
31 stars 43 forks source link

fix(apps): remove extra newline in logs #165

Closed Joshua-Anderson closed 8 years ago

Joshua-Anderson commented 8 years ago

Fixes #50

deis-bot commented 8 years ago

@bacongobbler, @mboersma and @ngauthier are potential reviewers of this pull request based on my analysis of git blame information. Thanks @Joshua-Anderson!

codecov-io commented 8 years ago

Current coverage is 5.15% (diff: 100%)

Merging #165 into master will not change coverage

@@            master      #165   diff @@
========================================
  Files           44        44          
  Lines         3159      3159          
  Methods          0         0          
  Messages         0         0          
  Branches         0         0          
========================================
  Hits           163       163          
  Misses        2972      2972          
  Partials        24        24

Powered by Codecov. Last update 6f11e8d...825152a

Joshua-Anderson commented 8 years ago

@bacongobbler Fixed, though it took me an embarrassingly long time to realize that the logs weren't parsed for escaped characters, so you have to look for the newline string instead of directly calling strings.TrimSpace()

Joshua-Anderson commented 8 years ago

This fix is encapsulated in #166.