fix(settings): remove duplicated 'v' in user agent

deis / workflow-cli

The CLI for Deis Workflow

http://deis.com

MIT License

31 stars 43 forks source link

fix(settings): remove duplicated 'v' in user agent #188

Closed aboyett closed 8 years ago

aboyett commented 8 years ago

the workflow-cli version is defined based on the git tag which already has a prepended v (v2.4.0) resulting in the user agent seen below

"GET /v2/apps/foo/pods/?limit=100 HTTP/1.1" 200 593 "Deis Client vv2.4.0"

Fixes #186

deis-bot commented 8 years ago

@Joshua-Anderson is a potential reviewer of this pull request based on my analysis of git blame information. Thanks @aboyett!

Joshua-Anderson commented 8 years ago

Jinks! 😄 I'm going to close my PR, #187 in favor of this one because I forgot to fix the tests.

aboyett commented 8 years ago

Whoops. Sorry about the duplicate PR @Joshua-Anderson. This was one of the bugs I noticed earlier, but the only one where I saw an obvious fix :smile:

Joshua-Anderson commented 8 years ago

No problem! Thank you for contributing!

codecov-io commented 8 years ago

Current coverage is 5.46% (diff: 100%)

Merging #188 into master will not change coverage

@@            master      #188   diff @@
========================================
  Files           48        48          
  Lines         3443      3443          
  Methods          0         0          
  Messages         0         0          
  Branches         0         0          
========================================
  Hits           188       188          
  Misses        3236      3236          
  Partials        19        19

Powered by Codecov. Last update 78118eb...4dce407