fix(limits): remove short cpu flag

deis / workflow-cli

The CLI for Deis Workflow

http://deis.com

MIT License

31 stars 43 forks source link

fix(limits): remove short cpu flag #216

Closed Joshua-Anderson closed 8 years ago

Joshua-Anderson commented 8 years ago

It conflicts with the global short config flag

deis-bot commented 8 years ago

@bacongobbler and @arschles are potential reviewers of this pull request based on my analysis of git blame information. Thanks @Joshua-Anderson!

codecov-io commented 8 years ago

Current coverage is 19.67% (diff: 0.00%)

Merging #216 into master will not change coverage

@@             master       #216   diff @@
==========================================
  Files            53         53          
  Lines          3736       3736          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            735        735          
  Misses         2900       2900          
  Partials        101        101

Powered by Codecov. Last update d49acf0...fc96f23

helgi commented 8 years ago

Make sure to update any docs as well

helgi commented 8 years ago

also I think we should ditch the memory short flag if CPU is getting it removed

Joshua-Anderson commented 8 years ago

also I think we should ditch the memory short flag if CPU is getting it removed

I like short flags, but I can see how it would get confusing.

Joshua-Anderson commented 8 years ago

@helgi Actually, I think I'm okay with leaving -m because --memory is pretty long and annoying to type. What do you think?

helgi commented 8 years ago

We can, I just feel like that's inconsistency is all