Closed Joshua-Anderson closed 7 years ago
@bacongobbler, @mboersma and @aledbf are potential reviewers of this pull request based on my analysis of git blame
information. Thanks @Joshua-Anderson!
No coverage report found for master at 05892a7.
Powered by Codecov. Last update 05892a7...03993f7
This PR needed a rebase. Opened a new, rebased PR here: https://github.com/deis/workflow-cli/pull/250
Does anybody else have a chance to review this PR?
This LGTM but i see another PR opened with your commit #250
Yep. Either one works for me! I can LGTM the other one if you'd rather see that one merged.
i LGTM the #250 as it has ci passing thought i don't see jenkins job on it.
Sorry I didn't add any tests for this. I'm not sure of any ways to easily test
config:pull
andconfig:push
because I need to mockos.ModeCharDevice
and I don't have the time to investigate it right now. 😢How to manually test:
Create a .env file with CRLF line endings and...
Before fix:
After fix: