search

deis / workflow-cli

The CLI for Deis Workflow
http://deis.com
MIT License
31 stars 43 forks source link

tests(parser): adding tests for parser package. #243

Closed ultimateboy closed 7 years ago

deis-bot commented 7 years ago

@kmala is a potential reviewer of this pull request based on my analysis of git blame information. Thanks @ultimateboy!

ultimateboy commented 7 years ago

Before ok github.com/deis/workflow-cli/parser 1.024s coverage: 1.5% of statements

After ok github.com/deis/workflow-cli/parser 1.111s coverage: 70.4% of statements

codecov-io commented 7 years ago

Current coverage is 72.18% (diff: 100%)

Merging #243 into master will increase coverage by 45.37%

@@             master       #243   diff @@
==========================================
  Files            57         57           
  Lines          3905       3905           
  Methods           0          0           
  Messages          0          0           
  Branches          0          0           
==========================================
+ Hits           1047       2819   +1772   
+ Misses         2716        778   -1938   
- Partials        142        308    +166

Powered by Codecov. Last update 2e26124...8a516ac

ultimateboy commented 7 years ago

Now: ok github.com/deis/workflow-cli/parser 1.181s coverage: 80.4% of statements

kmala commented 7 years ago

Unit tests for parser was supposed to also test the help commands https://github.com/deis/workflow-e2e/pull/308#r75555869. Do you want to tackle it separately or in this PR.

ultimateboy commented 7 years ago

@kmala Thanks for the issue reference. I'll see what I can do about getting help text covered tomorrow.

ultimateboy commented 7 years ago

@kmala In an attempt to keep this diff from growing too large. I'm going to save the testing of the help/usage text for another PR.

kmala commented 7 years ago

@ultimateboy sure...do we have an issue for that so that it can be tracked.Anyway this PR looks good.