Closed ultimateboy closed 7 years ago
Before
ok github.com/deis/workflow-cli/parser 1.024s coverage: 1.5% of statements
After
ok github.com/deis/workflow-cli/parser 1.111s coverage: 70.4% of statements
@@ master #243 diff @@
==========================================
Files 57 57
Lines 3905 3905
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 1047 2819 +1772
+ Misses 2716 778 -1938
- Partials 142 308 +166
Powered by Codecov. Last update 2e26124...8a516ac
Now: ok github.com/deis/workflow-cli/parser 1.181s coverage: 80.4% of statements
Unit tests for parser was supposed to also test the help commands https://github.com/deis/workflow-e2e/pull/308#r75555869. Do you want to tackle it separately or in this PR.
@kmala Thanks for the issue reference. I'll see what I can do about getting help text covered tomorrow.
@kmala In an attempt to keep this diff from growing too large. I'm going to save the testing of the help/usage text for another PR.
@ultimateboy sure...do we have an issue for that so that it can be tracked.Anyway this PR looks good.
@kmala is a potential reviewer of this pull request based on my analysis of
git blame
information. Thanks @ultimateboy!