deis / workflow-cli

The CLI for Deis Workflow
http://deis.com
MIT License
31 stars 43 forks source link

fix(config): support CRLF config files #250

Closed ultimateboy closed 7 years ago

deis-bot commented 7 years ago

@Joshua-Anderson, @bacongobbler and @mboersma are potential reviewers of this pull request based on my analysis of git blame information. Thanks @ultimateboy!

ultimateboy commented 7 years ago

Manually tested using both LF and CRLF line endings in a .env file. Both worked as expected. See the original PR (https://github.com/deis/workflow-cli/pull/229) for instructions on how to manually test.

codecov-io commented 7 years ago

Current coverage is 72.20% (diff: 0.00%)

Merging #250 into master will decrease coverage by 0.01%

@@             master       #250   diff @@
==========================================
  Files            57         57          
  Lines          3903       3904     +1   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           2819       2819          
- Misses          776        777     +1   
  Partials        308        308          

Powered by Codecov. Last update 002da75...207985e