search

deis / workflow-cli

The CLI for Deis Workflow
http://deis.com
MIT License
31 stars 43 forks source link

fix(healthcheck): show all the healthchecks set when no proctype is specified #259

Closed kmala closed 7 years ago

kmala commented 7 years ago

fixes https://github.com/deis/controller/issues/1030

deis-bot commented 7 years ago

@Joshua-Anderson, @ultimateboy and @bacongobbler are potential reviewers of this pull request based on my analysis of git blame information. Thanks @kmala!

codecov-io commented 7 years ago

Current coverage is 72.30% (diff: 100%)

Merging #259 into master will increase coverage by 0.07%

@@             master       #259   diff @@
==========================================
  Files            57         57          
  Lines          3915       3925    +10   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           2828       2838    +10   
  Misses          777        777          
  Partials        310        310

Powered by Codecov. Last update f43ba45...4aa36eb

ultimateboy commented 7 years ago

Before:

$ deis healthchecks:set liveness httpGet --type=asdf 80
Applying livenessProbe healthcheck... done

=== grassy-waggoner Healthchecks

asdf:
--- Liveness
Initial Delay (seconds): 50
Timeout (seconds): 50
Period (seconds): 10
Success Threshold: 1
Failure Threshold: 3
Exec Probe: N/A
HTTP GET Probe: Path="/" Port=80 HTTPHeaders=[]
TCP Socket Probe: N/A

--- Readiness
No readiness probe configured.

$ deis healthchecks:list
=== grassy-waggoner Healthchecks

web/cmd:
--- Liveness
No liveness probe configured.

--- Readiness
No readiness probe configured.

$ deis healthchecks:list --type=asdf
=== grassy-waggoner Healthchecks

asdf:
--- Liveness
Initial Delay (seconds): 50
Timeout (seconds): 50
Period (seconds): 10
Success Threshold: 1
Failure Threshold: 3
Exec Probe: N/A
HTTP GET Probe: Path="/" Port=80 HTTPHeaders=[]
TCP Socket Probe: N/A

--- Readiness
No readiness probe configured.

After:


$ deis healthchecks:set liveness httpGet --type=asdf 80
Applying livenessProbe healthcheck... done

=== grassy-waggoner Healthchecks

asdf:
--- Liveness
Initial Delay (seconds): 50
Timeout (seconds): 50
Period (seconds): 10
Success Threshold: 1
Failure Threshold: 3
Exec Probe: N/A
HTTP GET Probe: Path="/" Port=80 HTTPHeaders=[]
TCP Socket Probe: N/A

--- Readiness
No readiness probe configured.

$ deis healthchecks:list
=== grassy-waggoner Healthchecks

asdf:
--- Liveness
Initial Delay (seconds): 50
Timeout (seconds): 50
Period (seconds): 10
Success Threshold: 1
Failure Threshold: 3
Exec Probe: N/A
HTTP GET Probe: Path="/" Port=80 HTTPHeaders=[]
TCP Socket Probe: N/A

--- Readiness
No readiness probe configured.

web/cmd:
--- Liveness
No liveness probe configured.

--- Readiness
No readiness probe configured.

$ deis healthchecks:list --type=asdf
=== grassy-waggoner Healthchecks

asdf:
--- Liveness
Initial Delay (seconds): 50
Timeout (seconds): 50
Period (seconds): 10
Success Threshold: 1
Failure Threshold: 3
Exec Probe: N/A
HTTP GET Probe: Path="/" Port=80 HTTPHeaders=[]
TCP Socket Probe: N/A

--- Readiness
No readiness probe configured.