feat(auth): change --ssl-verify default to true

deis / workflow-cli

The CLI for Deis Workflow

http://deis.com

MIT License

31 stars 43 forks source link

feat(auth): change --ssl-verify default to true #265

Closed jschneiderhan closed 7 years ago

jschneiderhan commented 7 years ago

Changes the --ssl-verify default from false to true on both the auth:login and auth:register actions. This change should be backwards compatible with clusters using HTTP (since no SSL verification is performed) and clusters with valid SSL setups. Previously created profiles for clusters with invalid or self-signed certificates should continue to work, but new ones will require an explicit --ssl-verify false flag to be passed on register and login.

See discussion on #264

deis-bot commented 7 years ago

@Joshua-Anderson, @bacongobbler and @arschles are potential reviewers of this pull request based on my analysis of git blame information. Thanks @jschneiderhan!

codecov-io commented 7 years ago

Current coverage is 72.38% (diff: 55.55%)

Merging #265 into master will decrease coverage by 0.05%

@@             master       #265   diff @@
==========================================
  Files            57         57          
  Lines          3925       3925          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits           2843       2841     -2   
- Misses          773        774     +1   
- Partials        309        310     +1

Powered by Codecov. Last update 50451f8...be7ed7c

bacongobbler commented 7 years ago

let's slate this in for v2.9 so we can test this more in-depth.

jschneiderhan commented 7 years ago

👍 Sure. I'm in no rush! We're just explicitly setting the flag to true in the meantime.