search

deis / workflow-cli

The CLI for Deis Workflow
http://deis.com
MIT License
31 stars 43 forks source link

feat(label-cmd): add Label cmd #273

Closed zinuzoid closed 7 years ago

zinuzoid commented 7 years ago

Add Label model for workflow-cli new command Label. Labels are general key value string to each app just for administration purpose.

Require https://github.com/deis/controller-sdk-go/pull/106 See https://github.com/deis/workflow/issues/597

deis-bot commented 7 years ago

@Joshua-Anderson, @ultimateboy and @bacongobbler are potential reviewers of this pull request based on my analysis of git blame information. Thanks @zinuzoid!

kmala commented 7 years ago

Jenkins, Add to whitelist.

kmala commented 7 years ago

@zinuzoid Can you change the https://github.com/deis/workflow-cli/blob/master/glide.yaml#L19 to refer this commit https://github.com/deis/controller-sdk-go/commit/685c7f75bc1c4b57899a7cde55d945aa16129513

codecov-io commented 7 years ago

Current coverage is 72.44% (diff: 74.81%)

Merging #273 into master will increase coverage by 0.08%

@@             master       #273   diff @@
==========================================
  Files            57         59     +2   
  Lines          3933       4068   +135   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           2846       2947   +101   
- Misses          777        797    +20   
- Partials        310        324    +14

Powered by Codecov. Last update 8782839...8ab113f

kmala commented 7 years ago

Tested Manually:

ENG001599:example-go keerthanmala$ deis labels
=== karmic-mackinaw Label
No labels found.
ENG001599:example-go keerthanmala$ deis labels:set TEST=test1
Applying labels on karmic-mackinaw... done
ENG001599:example-go keerthanmala$ deis labels
=== karmic-mackinaw Label
TEST:            test1
ENG001599:example-go keerthanmala$ deis labels:unset TEST
Removing labels on karmic-mackinaw... done
ENG001599:example-go keerthanmala$ deis labels
=== karmic-mackinaw Label
No labels found.