search

deis / workflow-cli

The CLI for Deis Workflow
http://deis.com
MIT License
31 stars 43 forks source link

feat(Makefile): set docker build flags via environment variable #287

Closed mboersma closed 7 years ago

Joshua-Anderson commented 7 years ago

I don't know the full context behind this, but it will have a significant impact on development time for make test... from seconds to several minutes.

mboersma commented 7 years ago

@Joshua-Anderson it's true, which is why we've avoided doing this for so long, but building with cached Docker layers just means once in a while a bug is hidden and you don't discover it until later. In this case, switching the base image from ubuntu-slim to ubuntu broke a gunzip command for most images, but we didn't notice until building locally because a later Docker image layer was already cached in CI.

For developers, you can get the old behavior with:

DOCKER_BUILD_FLAGS= make docker-build
mboersma commented 7 years ago

See this https://github.com/deis/postgres/pull/180#issuecomment-273562141 for more details.

codecov-io commented 7 years ago

Current coverage is 72.58% (diff: 100%)

Merging #287 into master will not change coverage

@@             master       #287   diff @@
==========================================
  Files            59         59          
  Lines          4082       4082          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           2963       2963          
  Misses          792        792          
  Partials        327        327

Powered by Codecov. Last update 35fe6ad...cc60fa0

vdice commented 7 years ago

@mboersma when you get a chance, can you amend the commit and push again to kick of a fresh CI run?