Closed mboersma closed 8 years ago
Would it maybe make more sense to download the client binary _of the commit being tested_ from bintray so that the binary that is being distributed to people is the one being tested?
Is there a link on bintray to retrieve a specific commit? That would also be handy for install-v2.sh
because that script only grabs the latest client on master (which a user may not want when installing 2.0 a few months down the road, for example)
Is there a link on bintray to retrieve a specific commit?
https://bintray.com/deis/deisci/download_file?file_path=deis-<first 7 char of git sha>-<os>-<arch>
seems to work.
See #217. Still updating the test binary manually by SHA. 😞
What about if we wrote a lil' shell script to check to see if WORKFLOW_CLI_SHA (or something like that) is in the Docker run environment, and if so do what @Joshua-Anderson suggests. If not, download the latest version. Essentially it would be a deis cli shim...
note that now we've moved built binaries from bintray to google cloud storage, a sample URL to retrieve the CLI for a specific SHA would be: https://storage.googleapis.com/workflow-cli/08a0e40/deis-08a0e40-linux-amd64
I opened PR #233 to fix this.
Currently changes to workflow-cli won't be tested fully in e2e since the client is downloaded from bintray.