feat(limits-cmd): accept new limits:set value type

deis / workflow-e2e

End-to-end tests for Deis Workflow

MIT License

12 stars 18 forks source link

feat(limits-cmd): accept new limits:set value type #335

Closed zinuzoid closed 7 years ago

zinuzoid commented 7 years ago

Accept new cli format limits:set web=500m/2000m Value is map to requests/limits parameter in Kubernetes resource management. See https://github.com/deis/workflow/issues/562

deis-admin commented 7 years ago

Thanks for the contribution! Please ensure your commits follow our style guide. This code will be tested once a Deis maintainer reviews it.

deis-bot commented 7 years ago

@krancour, @bacongobbler and @mboersma are potential reviewers of this pull request based on my analysis of git blame information. Thanks @zinuzoid!

kmala commented 7 years ago

Jenkins, Add to whitelist.

mboersma commented 7 years ago

Jenkins, test this please.

vdice commented 7 years ago

@zinuzoid It looks like the added e2e specs still need some work to pass CI; see https://ci.deis.io/job/workflow-chart-e2e/235/console

bacongobbler commented 7 years ago

ping @zinuzoid ^^

zinuzoid commented 7 years ago

Hmm, I cannot see the console @vdice

HTTP ERROR 404
Problem accessing /job/workflow-chart-e2e/235/

zinuzoid commented 7 years ago

I did a rebase. seems pass now.

bacongobbler commented 7 years ago

very nice. 👍

vdice commented 7 years ago

@zinuzoid indeed, looks great! Thanks once again for the contribution!