Closed vdice closed 7 years ago
@mboersma, @Joshua-Anderson and @krancour are potential reviewers of this pull request based on my analysis of git blame
information. Thanks @vdice!
I worked with @vdice on this particular problem and can confirm it was hell to debug. This is a great compromise. LGTM
Nice! Deis V1 used to use gexpect with the python CLI, but when porting over to golang I had similar problems and wasn't able to track them down.
but when porting over to golang I had similar problems and wasn't able to track them down.
The mystery continues... 🔎
This is fine since it constitutes a test that would have caught the regression fixed by deis/workflow-cli#278. We can figure out the gexpect
dain bramage later.
The caveat here is the semi-interactive compromise. I could not get interactive password entry (and re-entry for confirmation) to work -- the cli always claimed the passwords did not match. After an initial dive/experimentation into the
gexpect
library code we use here, I determined quite a bit of effort would be needed to shape up the code to begin to debug...Therefore, I believe our bases are still covered (in checking behavior after an interactive register -- albiet only with username and email here). I can file a follow-up issue to revisit the aforementioned conundrum, if that is deemed necessary.