test(s) for default registration mode of admin_only

deis / workflow-e2e

End-to-end tests for Deis Workflow

MIT License

12 stars 18 forks source link

test(s) for default registration mode of admin_only #350

Closed vdice closed 7 years ago

vdice commented 7 years ago

As of Workflow v2.12.0, the default registration mode has changed to admin_only. The temporary workaround for e2e is to install the chart with controller.registration_mode=enabled as this is how the current suite of tests expects the cluster to be set up.

We will now need tests and/or a new suite to exercise the new default of admin_only.

vdice commented 7 years ago

At high level, this is the following strategy we're going to pursue for this issue:

leave one failing non-admin auth:register spec in the tests, expecting it to fail
rewrite the register helper method to assume it's an admin registering the user (which should fix the rest of the tests)
revert the --set controller.registration_mode=enabled e2e-runner flag so we are testing the new default