search

deis / workflow-e2e

End-to-end tests for Deis Workflow
MIT License
12 stars 18 forks source link

fix(tests/auth): no interactive register for admin #352

Closed vdice closed 7 years ago

vdice commented 7 years ago

We appear to be getting bitten by an intermittent error in a dependency for the gexpect library -- we only use it for the one interactive registration bit of code, and I believe we would rather relegate this testing to manual interaction rather than struggle with the quirks of this library...

for example, from https://ci.deis.io/job/workflow-chart-e2e/1042/console

15:03:08 [BeforeSuite] BeforeSuite 
15:03:08 /go/src/github.com/deis/workflow-e2e/tests/tests_suite_test.go:96
15:03:08 
15:03:08   Expected error:
15:03:08       <*os.PathError | 0xc4201807e0>: {Op: "read", Path: "/dev/ptmx", Err: 0x5}
15:03:08       read /dev/ptmx: input/output error
15:03:08   not to have occurred
15:03:08 
15:03:08   /go/src/github.com/deis/workflow-e2e/tests/cmd/auth/commands.go:35
deis-bot commented 7 years ago

@krancour and @bacongobbler are potential reviewers of this pull request based on my analysis of git blame information. Thanks @vdice!