Integrate CronJob + garbage collector

deis / workflow-e2e

End-to-end tests for Deis Workflow

MIT License

12 stars 18 forks source link

Integrate CronJob + garbage collector #355

Closed mboersma closed 7 years ago

mboersma commented 7 years ago

The e2e chart currently uses a DaemonSet with the spotify-gc container to clean up stale Docker image layers and keep the graph from getting too large. But this is clumsy; it continually fails and CrashLoops with an exponential backoff that becomes stupidly large very quickly.

There must be some way to use the new CronJob construct to run a garbage collector sidecar on each node with a regular schedule.

vdice commented 7 years ago

PR issued in https://github.com/kubernetes/charts/pull/982; chart installed on staging cluster for testing and docs updated with this info.

vdice commented 7 years ago

Oops; accidentally closed. TODOs remaining for this issue are:

remove sidecar container from workflow-e2e chart
ensure spotify-docker-gc chart is installed on any leasable e2e clusters

vdice commented 7 years ago

This needs to wait until the chart is in stable; see https://github.com/kubernetes/charts/pull/982

vdice commented 7 years ago

Work completed in https://github.com/deis/workflow-e2e/pull/362 ; closing.