search

deis / workflow-e2e

End-to-end tests for Deis Workflow
MIT License
12 stars 18 forks source link

RBAC amendments for e2e #358

Closed vdice closed 7 years ago

vdice commented 7 years ago

Currently, e2e doesn't run against a Workflow install with RBAC enabled (would need to --set global.use_rbac=true). (See https://github.com/deis/workflow/pull/812 for addition, scheduled for v2.15)

However, if/when we decided to do so, there appear to be the following changes/amendments needed (seen testing locally):

  1. Lines like this one in the tags tests error out with the following:

    $ HOME=/root kubectl get nodes -o jsonpath={.items[*].metadata..labels}
error: group map[autoscaling:0xc820321ea0 batch:0xc8203d4070 certificates.k8s.io:0xc8203d40e0 componentconfig:0xc8203d4150 extensions:0xc8203d4230 policy:0xc8203d42a0 :0xc820321c00 apps:0xc820321c70 rbac.authorization.k8s.io:0xc8203d4310 storage.k8s.io:0xc8203d4380 authorization.k8s.io:0xc820321e30 federation:0xc820321730 authentication.k8s.io:0xc820321ce0] is already registered

  2. Same for similar kubectl invocations in the limits tests.

  3. Other?

vdice commented 7 years ago

Turns out the errors described above were a result of using an older version of k8s (1.4.6) -- PR has been issued to update this version: https://github.com/deis/workflow-e2e/pull/361

Will update this issue if anything actually related to RBAC + e2e is found; otherwise will close.

vdice commented 7 years ago

Interestingly, the only test failure I am reliably seeing now when running against a Workflow install w/ global.use_rbac=true is the user can run a command with lengthy output in that app's environment test which I've actually been trying to amend in https://github.com/deis/workflow-e2e/pull/363

vdice commented 7 years ago

Closing for now; I don't see any amendments needed at this time. (error described in https://github.com/deis/workflow-e2e/issues/358#issuecomment-305037560 can also be hit on non-RBAC clusters.)