search

deis / workflow-e2e

End-to-end tests for Deis Workflow
MIT License
12 stars 18 forks source link

apps:run test with lengthy output -- don't log actual output on failure #360

Open vdice opened 7 years ago

vdice commented 7 years ago

When/if this apps:run test fails, the Expect statement proceeds to log the entire command's output, corrupting the user's terminal and crowding out logs with byte code.

We should re-jigger the test, perhaps checking first if the byte array does not match expected (outside of Expect) and then, if not, logging some standard error/failure message accordingly.

vdice commented 7 years ago

Alas, since the output is stored in sess.Out.ContentsI(), Ginkgo will log this anytime the test fails (no matter how test is failed). Wondering if there's another way to eliminate logging of output? Or, another way to test this case? ping @mboersma

Cryptophobia commented 6 years ago

This issue was moved to teamhephy/workflow-e2e#2