Closed kmala closed 8 years ago
@kmala 💯 on this. The major TODOs here:
Moving out of RC1, as this is not essential for the RC
Note that https://github.com/deis/workflow-manager/pull/59 may not be merged until this PR is
Code LGTM. Note that https://github.com/deis/workflow-manager-api/issues/142 addresses the first bullet point above ("Get backward compatibility back (as discussed above in #138 (comment))"), and we'll need to wait to test backward compatibility until #142 is fixed
@kmala doesn't this code eliminate the existing (backward compatible) endpoints that workflow-manager-api already ran?
also, I found that the workflow-manager client uses
v2
as the API version (https://github.com/deis/charts/blob/master/workflow-dev/tpl/deis-workflow-manager-rc.yaml#L38-L39), so it may be a good idea to usev3
as the version in the swagger spec, so we can run both thev2
andv3
servers side by side with no backward compatibility breakage