feat(swagger):handle the requests using swagger stubs

deis / workflow-manager-api

Deis Workflow Manager API

MIT License

5 stars 0 forks source link

feat(swagger):handle the requests using swagger stubs #138

Closed kmala closed 8 years ago

arschles commented 8 years ago

@kmala doesn't this code eliminate the existing (backward compatible) endpoints that workflow-manager-api already ran?

also, I found that the workflow-manager client uses v2 as the API version (https://github.com/deis/charts/blob/master/workflow-dev/tpl/deis-workflow-manager-rc.yaml#L38-L39), so it may be a good idea to use v3 as the version in the swagger spec, so we can run both the v2 and v3 servers side by side with no backward compatibility breakage

arschles commented 8 years ago

@kmala 💯 on this. The major TODOs here:

Get backward compatibility back (as discussed above in https://github.com/deis/workflow-manager-api/pull/138#issuecomment-220702464)
Test with a workflow-manager instance that uses the generated client code

arschles commented 8 years ago

Moving out of RC1, as this is not essential for the RC

arschles commented 8 years ago

Note that https://github.com/deis/workflow-manager/pull/59 may not be merged until this PR is

arschles commented 8 years ago

Code LGTM. Note that https://github.com/deis/workflow-manager-api/issues/142 addresses the first bullet point above ("Get backward compatibility back (as discussed above in #138 (comment))"), and we'll need to wait to test backward compatibility until #142 is fixed