search

deis / workflow-manager-api

Deis Workflow Manager API
MIT License
5 stars 0 forks source link

feat(restapi): add ability to use any arbitrary postgres DB #162

Closed arschles closed 7 years ago

arschles commented 8 years ago

not just RDS

Fixes https://github.com/deis/workflow-manager-api/issues/141 Closes https://github.com/deis/workflow-manager-api/pull/158

krancour commented 8 years ago

@arschles what database does this use out-of-the-box? i.e. controller, by default, uses the on-cluster postgres in deis-database. What does this use? I'm asking because I think we should be conscious of making off-cluster db configuration as easy for this as it is for the controller. (i.e. easily done via generate_params.toml).

arschles commented 8 years ago

@krancour this uses RDS out of the box (as of https://github.com/deis/workflow-manager-api/pull/162/commits/a9085d8f4d91266d0c48dc45ecf6eaea23814cb3), and in that case requires only the WORKFLOW_MANAGER_API_RDS_REGION env var. It gets the rest of the DB connection information from the AWS API.

Also, sidenote - this component has no helm chart - everything is deployed & configured via deis itself.

arschles commented 8 years ago

Also note that in the in-cluster case, this patch will make wfm-api require a secret, so we'll have to add a helm chart or similar

arschles commented 8 years ago

Removing from the 2.2 milestone, as it was never a necessary deliverable for that milestone

mboersma commented 7 years ago

I'm closing this PR since it's a year old 🎂, but @arschles please re-open if the code here is still relevant.