Closed kmala closed 8 years ago
@kmala is this PR intended to just create the swagger file and generate the client code. If so, I'm fine with that fwiw. Is there an issue for converting this codebase to use the generated client code?
@arschles this does nothing but just generate the client code, the swagger specification is part of #43
@kmala sgtm! I'm ready for a big rebase in https://github.com/deis/workflow-manager/pull/42 when this is merged, and excited to utilize the client code in there too :)
@kmala left one comment at https://github.com/deis/workflow-manager/pull/44#discussion_r63563881. Assuming that's resolved, this LGTM.
Also, you may be able to resolve the test failures by adding the following to the glide.yaml
:
package: speter.net/go/exp/math/dec/inf
repo: https://github.com/bellua/inf
vcs: git
@kmala does this require https://github.com/deis/workflow-manager/pull/43/files before merge?
yes...it requires
Can you clean up the commit messages? Something like:
feat(swagger): generate client stub for wfm API spec
chore(glide): add swagger to dependencies
feat(swagger): run "generate client" after rebase
cleaned up the commit messages
@kmala does this require https://github.com/deis/workflow-manager-api/pull/138?
@arschles no it doesn't
@kmala ah, I see. this is only the generated code
ref https://github.com/deis/workflow-manager-api/issues/80