deis / workflow-manager

Deis Workflow Manager: Cluster First Aid
MIT License
14 stars 15 forks source link

feat(swagger): generate client stub for wfm API spec #44

Closed kmala closed 8 years ago

kmala commented 8 years ago

ref https://github.com/deis/workflow-manager-api/issues/80

arschles commented 8 years ago

@kmala is this PR intended to just create the swagger file and generate the client code. If so, I'm fine with that fwiw. Is there an issue for converting this codebase to use the generated client code?

kmala commented 8 years ago

@arschles this does nothing but just generate the client code, the swagger specification is part of #43

arschles commented 8 years ago

@kmala sgtm! I'm ready for a big rebase in https://github.com/deis/workflow-manager/pull/42 when this is merged, and excited to utilize the client code in there too :)

arschles commented 8 years ago

@kmala left one comment at https://github.com/deis/workflow-manager/pull/44#discussion_r63563881. Assuming that's resolved, this LGTM.

Also, you may be able to resolve the test failures by adding the following to the glide.yaml:

package: speter.net/go/exp/math/dec/inf
repo: https://github.com/bellua/inf
vcs: git
arschles commented 8 years ago

@kmala does this require https://github.com/deis/workflow-manager/pull/43/files before merge?

kmala commented 8 years ago

yes...it requires

mboersma commented 8 years ago

Can you clean up the commit messages? Something like:

feat(swagger): generate client stub for wfm API spec
chore(glide): add swagger to dependencies
feat(swagger): run "generate client" after rebase
kmala commented 8 years ago

cleaned up the commit messages

arschles commented 8 years ago

@kmala does this require https://github.com/deis/workflow-manager-api/pull/138?

kmala commented 8 years ago

@arschles no it doesn't

arschles commented 8 years ago

@kmala ah, I see. this is only the generated code