deis / workflow-manager

Deis Workflow Manager: Cluster First Aid
MIT License
14 stars 15 forks source link

fix(boot.go,jobs/jobs.go): fix panic on startup #56

Closed arschles closed 8 years ago

arschles commented 8 years ago

Summary Of Issues

I opened this pull request to fix the panic described in #54. After fixing the panic described in that issue, I uncovered the following other bugs, in order of the below listing. Since each bug uncovers the next in turn, I believe that the fixes all need to be included into a single PR, even if this PR is large in scope.

This PR include the following fixes to address the above issues:

Fixes https://github.com/deis/workflow-manager/issues/55 Fixes https://github.com/deis/workflow-manager/issues/54

Still TODO

mention-bot commented 8 years ago

By analyzing the blame information on this pull request, we identified @jackfrancis to be a potential reviewer

bacongobbler commented 8 years ago

From my naive surface-deep code review (not too well versed with workflow-manager... Need to do a deep dive one day), this all looks good to me.