search

deis / workflow-manager

Deis Workflow Manager: Cluster First Aid
MIT License
14 stars 15 forks source link

ref(swagger):add /v2 endpoints to support existing clients #62

Closed kmala closed 8 years ago

krancour commented 8 years ago

What are the existing clients we are trying to support by doing this?

kmala commented 8 years ago

all the beta and rc workflow-manger containers

krancour commented 8 years ago

I wouldn't think it's necessary to provide backward compatibility with anything that is pre-GA.

kmala commented 8 years ago

yes...i agree with you but this is special scenario for us as we want to know the information of what people are running currently especially how many are in beta and are upgrading to stable

krancour commented 8 years ago

this is special scenario for us as we want to know the information of what people are running currently

Right. I forgot about that. But isn't that more relevant for whatever centralized component we host for wfm to talk back to?

arschles commented 8 years ago

@krancour yes, you're right. the versions server should provide full backward compatibility, and ironically that's what this PR works toward. the swagger document here is the API definition shared by the client and the server. the workflow-manager client code will use the v3 endpoints but this change will allow the server to handle old clients that use the v2 endpoints