ref(data): s/getDeisRCItems/getRCItems

deis / workflow-manager

Deis Workflow Manager: Cluster First Aid

MIT License

14 stars 15 forks source link

ref(data): s/getDeisRCItems/getRCItems #68

Closed jackfrancis closed 8 years ago

jackfrancis commented 8 years ago

This helper function was recently refactored; its original goal was to statically return ReplicationController objects in the "deis" namespace, but now its namespace (and other) specifications are passed in as an rc.Lister.

Thus, renaming the newer, generic rc items getter to getRCItems to reflect this.

deis-bot commented 8 years ago

@arschles and @kmala are potential reviewers of this pull request based on my analysis of git blame information. Thanks @jackfrancis!

jackfrancis commented 8 years ago

Testing ramifications: this change is purely aesthetic (function rename), requiring no new tests (though I'm not speaking to any preëxisting unit test coverage issues in this area of code). Running make test locally is a fine way to sanity check.

jackfrancis commented 8 years ago

Fixes #64