search

deis / workflow-manager

Deis Workflow Manager: Cluster First Aid
MIT License
14 stars 15 forks source link

feat(auth): add basic auth to check if the user is admin #74

Closed smothiki closed 8 years ago

smothiki commented 8 years ago

Add basic auth for deis cli to authenticate for admin

deis-bot commented 8 years ago

@jackfrancis and @arschles are potential reviewers of this pull request based on my analysis of git blame information. Thanks @smothiki!

helgi commented 8 years ago

Couldn't this use the controller-go-sdk?

smothiki commented 8 years ago

Couldn't this use the controller-go-sdk?

can;t use controller-go-sdk as we have to send deis controller api version in the header for the response

arschles commented 8 years ago

@smothiki LGTM assuming https://github.com/deis/workflow-manager/pull/74#discussion_r68433975 is addressed

smothiki commented 8 years ago

Closing this PR in favor of recent discussion on how to implement Auth