cluster_id is vulnerable to race condition when called concurrently

deis / workflow-manager

Deis Workflow Manager: Cluster First Aid

MIT License

14 stars 15 forks source link

cluster_id is vulnerable to race condition when called concurrently #94

Closed jackfrancis closed 8 years ago

jackfrancis commented 8 years ago

The Get() method is in fact an "insert if not exist"-style retriever, so it should be protected with a RW lock.

fixes #93

deis-bot commented 8 years ago

@arschles and @kmala are potential reviewers of this pull request based on my analysis of git blame information. Thanks @jackfrancis!

codecov-io commented 8 years ago

Current coverage is 43.47% (diff: 0.00%)

Merging #94 into master will increase coverage by 0.21%

@@             master        #94   diff @@
==========================================
  Files            11         11          
  Lines           578        582     +4   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits            250        253     +3   
- Misses          284        285     +1   
  Partials         44         44

Powered by Codecov. Last update 2582640...dc8ee48