feature(data): add deployments, daemonsets to cluster data

deis / workflow-manager

Deis Workflow Manager: Cluster First Aid

MIT License

14 stars 15 forks source link

feature(data): add deployments, daemonsets to cluster data #95

Closed jackfrancis closed 8 years ago

jackfrancis commented 8 years ago

installedDeisData.Get() now employs the Deployments(), DaemonSets() k8s interfaces in addition to ReplicationControllers() in order to present a complete set of workflow components when gathering cluster data.

Includes basic test coverage, with the caveat that because our current interfaces act as a union between the api and extensions resources, we'll probably need to build out our own fake client library in order to fully test.

deis-bot commented 8 years ago

@kmala, @arschles and @smothiki are potential reviewers of this pull request based on my analysis of git blame information. Thanks @jackfrancis!

codecov-io commented 8 years ago

Current coverage is 45.95% (diff: 48.38%)

Merging #95 into master will increase coverage by 2.48%

@@             master        #95   diff @@
==========================================
  Files            11         11          
  Lines           582        618    +36   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits            253        284    +31   
- Misses          285        287     +2   
- Partials         44         47     +3

Powered by Codecov. Last update 31fe3bc...ee97538

mboersma commented 8 years ago

we'll probably need to build out our own fake client library in order to fully test

If that's out of scope for the next Workflow release, let's make sure to create an issue to track it. Unless #38 covers it.

jackfrancis commented 8 years ago

@mboersma good idea: https://github.com/deis/workflow-manager/issues/96

jackfrancis commented 8 years ago

fixes #90