deislabs / bindle

Bindle: Object Storage for Collections
Apache License 2.0
263 stars 37 forks source link

Make "unknown error" client errors a bit more informative #323

Closed itowlson closed 2 years ago

itowlson commented 2 years ago

The current "Unknown error" is very hard to diagnose because it depends on the server providing everything you need in the message. This is not a good thing to rely on, especially for unfortunate server devs trying to get their stuff working with the existing client, so this PR adds the following information to the "unknown error" message:

A minor change is that it will now say Unknown error: (no error message in response) rather than a trailing colon and space Unknown error:. A complete message now looks like Unknown error response: Create to http://localhost:5000/v1/_i/weather/1.2.3-ivan-20220317112555054@a4d030d845438e530f12cbf85422e82a65327443786e0c9f59fbbf282adde7e3 returned status 201 Created: (no error message in response)

itowlson commented 2 years ago

@thomastaylor312 do you own the GH actions for this? I am getting a failure on something to do with large regexes, but my PR does not change anything involving large regexes.

thomastaylor312 commented 2 years ago

@itowlson Yeah, this is due to a new RUSTSEC vulnerability. It shouldn't effect us but running a cargo update should solve the problem