feat(release): build binary for ARM/aarch64 Linux in release workflow

deislabs / bindle

Bindle: Object Storage for Collections

Apache License 2.0

263 stars 37 forks source link

feat(release): build binary for ARM/aarch64 Linux in release workflow #328

Closed VishnuJin closed 2 years ago

VishnuJin commented 2 years ago

fixes #325

This PR adds step to build binary for Linux aarch64 to Bindle releases

VishnuJin commented 2 years ago

currently facing issue with the compilation of ring in aarch64

My Build URL - https://github.com/VishnuJin/bindle/runs/5759376008?check_suite_focus=true

error: failed to run custom build command for `ring v0.16.20`

VishnuJin commented 2 years ago

currently facing issue with the compilation of ring in aarch64

My Build URL - https://github.com/VishnuJin/bindle/runs/5759376008?check_suite_focus=true
error: failed to run custom build command for `ring v0.16.20`

this is now resolved

VishnuJin commented 2 years ago

ran in to another issue, this one with hyper

https://github.com/VishnuJin/bindle/runs/5774669863?check_suite_focus=true

error adding symbols: file in wrong format
[650](https://github.com/VishnuJin/bindle/runs/5774669863?check_suite_focus=true#step:12:650)
          collect2: error: ld returned 1 exit status
[651](https://github.com/VishnuJin/bindle/runs/5774669863?check_suite_focus=true#step:12:651)

[652](https://github.com/VishnuJin/bindle/runs/5774669863?check_suite_focus=true#step:12:652)

[653](https://github.com/VishnuJin/bindle/runs/5774669863?check_suite_focus=true#step:12:653)
error: could not compile `hyper` due to previous error
[653](https://github.com/VishnuJin/bindle/runs/5774669863?check_suite_focus=true#step:12:653)
Error: The process '/home/runner/.cargo/bin/cargo' failed with exit code 101

VishnuJin commented 2 years ago

ran in to another issue, this one with hyper

https://github.com/VishnuJin/bindle/runs/5774669863?check_suite_focus=true

error adding symbols: file in wrong format
[650](https://github.com/VishnuJin/bindle/runs/5774669863?check_suite_focus=true#step:12:650)
          collect2: error: ld returned 1 exit status
[651](https://github.com/VishnuJin/bindle/runs/5774669863?check_suite_focus=true#step:12:651)

[652](https://github.com/VishnuJin/bindle/runs/5774669863?check_suite_focus=true#step:12:652)

[653](https://github.com/VishnuJin/bindle/runs/5774669863?check_suite_focus=true#step:12:653)
error: could not compile `hyper` due to previous error
[653](https://github.com/VishnuJin/bindle/runs/5774669863?check_suite_focus=true#step:12:653)
Error: The process '/home/runner/.cargo/bin/cargo' failed with exit code 101

resolved by adding linker path in cargo config

VishnuJin commented 2 years ago

@radu-matei @thomastaylor312 Success build for Linux aarch64 in my repo - https://github.com/VishnuJin/bindle/runs/5775720248?check_suite_focus=true

VishnuJin commented 2 years ago

@vdice hmm but just wondering in Krustlet we have .cargo folder in the repo so I thought its fine for bindle as well ?

vdice commented 2 years ago

@VishnuJin Ok, it's probably fine -- and could be useful when/if other targets are added as well. 👍

vdice commented 2 years ago

Thank you @VishnuJin !