Closed dicej closed 2 years ago
@thomastaylor312 Thanks for merging this. I'd like to pull this fix into Spin. Is there a release planned soon-ish? If not, I'd be happy to help make one happen.
Yeah I have #334 that I need to tie up and merge. Then we can cut a new release. This one will be a pretty big breaking release so we'll need to document it well
Per https://github.com/fermyon/spin/issues/180#issuecomment-1118022050, we discovered that, on POSIX systems with a default file descriptor limit of 1024, pushing a bindle containing many assets using
StandaloneRead::push
results in a "Too many open files" error. This is due to the unlimited concurrency offuture::join_all
.Steps to reproduce:
ulimit -n 1024
(this is the default on most systems).spin-kitchensink
project directory, usespin
to push the bindle to your favoritebindle-server
and observe the output:Setting the file limit to a sufficiently large number will fix the problem, but that may not be possible if the user does not have sufficient privileges.
I have a fix for this and will open a PR shortly.