deislabs / bindle

Bindle: Object Storage for Collections
Apache License 2.0
263 stars 37 forks source link

feat: push docker image #352

Closed FrankYang0529 closed 1 year ago

FrankYang0529 commented 1 year ago

ref: https://github.com/fermyon/installer/issues/63, https://github.com/fermyon/installer/pull/100#issuecomment-1276462821

FrankYang0529 commented 1 year ago

@microsoft-github-policy-service agree [company="default"]

FrankYang0529 commented 1 year ago

@microsoft-github-policy-service agree

FrankYang0529 commented 1 year ago

Defer to the code owners for final decision, but I'm wondering if we want to push to this repo's GitHub container registry instead (ghcr.io/deislabs/bindle)? We should be able to use the default $GITHUB_TOKEN to push images.

Yeah, I think it's good to use the default $GITHUB_TOKEN and we don't need to maintain docker credentials. Thanks. Updated it!