search

deislabs / bindle

Bindle: Object Storage for Collections
Apache License 2.0
263 stars 37 forks source link

chore(release/0.8): cherry-pick CI features/fixes #359

Closed vdice closed 1 year ago

vdice commented 1 year ago

@thomastaylor312 and @bacongobbler, does the following look like the right approach towards the goal of backporting some CI improvements/fixes into a v0.8.x release (would be v0.8.2 as of writing)?

Ref https://github.com/deislabs/bindle/issues/325

It incorporates both the linux-aarch64 build support and the blob-store action bump/fix. I ran the following:

git checkout release/0.8

# cherry-pick the linux-aarch64 commit
git cherry-pick f7e31ccc5587c7444ef73bba702ec082f37cf345

# cherry-pick the azure-blob-store bump
git cherry-pick a5ba2c91cbfd7e1099c432cd4ae6c9e88b32f94a

edit: also added this change to pass CI: https://github.com/deislabs/bindle/pull/359/commits/05d7a2557f12b399f44a2f1298df25f3349b6d47 ; ref https://github.com/deislabs/bindle/pull/359#issuecomment-1347318904

If so, then I suppose we'd merge this into release/0.8 and then tag/push v0.8.2 from HEAD of this branch?

thomastaylor312 commented 1 year ago

The one failure is an easy fix. See this commit: https://github.com/deislabs/bindle/commit/f026e9aa0511a85a428f3febac0bcf2b83019a98

Probably shouldn't cherry pick it as it has lock changes as well