deislabs / containerd-wasm-shims

containerd shims for running WebAssembly workloads in Kubernetes
Apache License 2.0
311 stars 48 forks source link

fix: spin build failed #109

Closed dierbei closed 1 year ago

dierbei commented 1 year ago

Fix #108

Mossaka commented 1 year ago

Thanks for your contribution!

This does resolve the problem that #108 brings. However, I'd love to propose an alternative way - instead of adding another target at the build-spin step, could we add it to a install-rust-targets target that does something similar to https://github.com/deislabs/containerd-wasm-shims/blob/main/.github/workflows/build.yaml#L30-L33?

This allows us to reuse the same step in both the CI and local dev environment.

dierbei commented 1 year ago

@microsoft-github-policy-service agree

Mossaka commented 1 year ago

@dierbei could you please sign your commits?

dierbei commented 1 year ago

@Mossaka I tried doing a rebase so maybe the commit will be clearer.