search

deislabs / containerd-wasm-shims

containerd shims for running WebAssembly workloads in Kubernetes
Apache License 2.0
311 stars 48 forks source link

Feature/Redis Trigger #117

Closed suneetnangia closed 1 year ago

suneetnangia commented 1 year ago

Added Redis trigger support in addition to existing http in the shim. I'll add integration test support for this and also the existing "spin-outbound-redis" in next PR.

We are currently using a private version of this shim in our repo to demo wasm/containers messaging using Redis in K3d. https://github.com/suneetnangia/wasm-orchestration-with-spin

P.S. Let me know if you want to make any changes. Thanks

suneetnangia commented 1 year ago

All done @Mossaka. Thanks

Mossaka commented 1 year ago

I am going to merge this in and we can have follow ups resolved in future PRs.

suneetnangia commented 1 year ago

lgtm!

Would you like to add the spin-inbound-redis image to the release pipeline? @suneetnangia

Can do, but was wondering if I should add integration tests for redis based images (both inbound and outbound (existing)) prior to release, to ensure images always work when we make changes?

Mossaka commented 1 year ago

@suneetnangia it's always a good idea to add more integration tests, specifically for redis based images.