search

deislabs / containerd-wasm-shims

containerd shims for running WebAssembly workloads in Kubernetes
Apache License 2.0
311 stars 48 forks source link

No Spin logs in release #186

Closed 0xE282B0 closed 9 months ago

0xE282B0 commented 11 months ago

Hi, I noticed that with the release (at least 0.9.3 and 0.10.0) there are again no logs from within the module. When I check out the 0.10.0 tag and do a make install the logs are working.

Expected output with the ghcr.io/deislabs/containerd-wasm-shims/example s/spin-rust-hello:latest image after calling localhost:80/hello:

Serving http://0.0.0.0:80
Available Routes:
  hello: http://0.0.0.0:80/hello
  go-hello: http://0.0.0.0:80/go-hello
Hello, world! You should see me in pod logs

Could it be something related to the binary stripping during release process?

Mossaka commented 11 months ago

When I check out the 0.10.0 tag and do a make install the logs are working.

That't super strange. Umm I am not sure the binary stripping would affect logging as it's set up with spin's hooks.

Mossaka commented 9 months ago

Hey @0xE282B0 , could you please veirfy that the binary you were using is indeed v0.10.0?

0xE282B0 commented 9 months ago

Hi, There was indeed no problem with the release, only the log message was removed from the test image in this commit a week before. I guess I had an old version cached in my cluster where the log message was still there, and with the K3d quickstart cluster I didn't see it because it was removed from the code.

In short, the actual behavior of the test image is that the /hello endpoint does not log anything, but the /go-hello endpoint does. I'll close this issue.